bpo-43172: readline now passes its tests when built against libedit #24499
+62
−15
Conversation
Existing irreconcilable API differences remain in readline.get_begidx and eadline.get_endidx behavior based on libreadline vs libedit use.
|
There isn't anyone who'd consider themselves an expert on this ancient module's internals as far as I can see... mostly waiting on CI tests and any other pair of C focused eyeballs. |
|
buildbot tests look good, the three red ones are unrelated. |
fd053fd
into
python:master
66 of 69 checks passed
66 of 69 checks passed
bedevere/news
News entry found in Misc/NEWS.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Existing irreconcilable API differences remain in readline.get_begidx and readline.get_endidx behavior based on libreadline vs libedit use.
https://bugs.python.org/issue43172