Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db.sqlite3-journal to Python.gitignore #3063

Merged
merged 1 commit into from May 25, 2019
Merged

Conversation

@captainpete
Copy link
Contributor

@captainpete captainpete commented May 20, 2019

Hi there!

Reasons for making this change:

A similar change was introduced in 15e56af into Rails.gitignore, see #1280.
We've just come across the same need for this in a project in Python (Django) and found it wasn't in the github gitignore. h/t @nickittynack.

Links to documentation supporting these rule changes:

Docs on Sqlite temporary files
https://www.sqlite.org/tempfiles.html#rollback_journals

No real upstream changes I can make out, just something that was missing.

Please let me know if the quality of this PR can be improved.
Thanks!

See also 15e56af introduced this for Rails.gitignore.

Docs on Sqlite temporary files
https://www.sqlite.org/tempfiles.html#rollback_journals

Thanks @nickittynack (Nick Reynolds)
Copy link
Member

@shiftkey shiftkey left a comment

Thanks @captainpete!

@shiftkey shiftkey merged commit c1faae4 into github:master May 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Ortega-Dan added a commit to Ortega-Dan/gitignore that referenced this pull request Jun 26, 2019
See also 15e56af introduced this for Rails.gitignore.

Docs on Sqlite temporary files
https://www.sqlite.org/tempfiles.html#rollback_journals

Thanks @nickittynack (Nick Reynolds)
SaifurRahmanMohsin added a commit to SaifurRahmanMohsin/gitignore that referenced this pull request Jul 17, 2019
* upstream/master:
  Update Laravel.gitignore (github#3098)
  Ignore *.xyd outline files generated by xy LaTeX package (github#3088)
  Updating Joomla.gitignore to Joomla! 3.9.8 (github#3090)
  KiCAD: the -rescue.lib file is also precious! (github#3025)
  Revert "KiCad: add footprint cache (github#3043)" (github#3075)
  Add db.sqlite3-journal to Python.gitignore (github#3063)
  Make ignoring .ist files for glossaries-extra ... (github#3066)
r2pgl added a commit to r2pgl/gitignore that referenced this pull request Mar 15, 2020
See also 15e56af introduced this for Rails.gitignore.

Docs on Sqlite temporary files
https://www.sqlite.org/tempfiles.html#rollback_journals

Thanks @nickittynack (Nick Reynolds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants