Go: Revert "Add vendor folder to Go.gitignore" #2183
Conversation
This reverts commit 14740a5. Any Go developers sometimes static vendoring into vendor directory. Because for the delete vendored repository, reliably build with vendor packages or etc. In Go language development, ignoring vendor directory is should be left to the package authors. Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
|
/cc @futabooo |
|
you have got a point. below is my opinion.
I think it is not good,It is better to use package management
how about this?
|
Yeah, That is our gopher's ideal. like ruby's Also, If package manager supports the good vendoring feature, still have depends on the existence of the github repository. Well, I always delete it and create a .gitignore, so there is no problem. If you do not like it, I will close it :) |
|
@zchee |
|
Vendoring support is officially supported as of go1.6, which means the There are a number of projects, including widely used projects like docker, which uses the I don't believe this is a matter of personal choice, but should be considered for the consistency between Go project's specification/official tooling support and the expectation of a conservative, default |
|
Closing due to conflicts. @zchee please have a look at the latest file and see if anything needs to be incorporated. |
This reverts commit 14740a5.
Reasons for making this change:
Any Go developers sometimes static vendoring into vendor directory.
Because for the delete vendoring packages repository, reliably build with
vendor packages or etc.
Also, A typical vendoring tool such as
gb,gvtwill createmanifestfile onvendordirectory.In Go language development, ignoring vendor directory is should be
left to the package authors.(I think)
Links to documentation supporting these rule changes:
https://github.com/derekparker/delve/tree/master/vendor
https://github.com/zchee/docker-machine-driver-xhyve/tree/master/vendor