bpo-42979: Use _Py_CheckSlotResult() to check slots result #24356

vstinner · 2021-01-28T00:07:43Z

When Python is built in debug mode (with C assertions), calling a
type slot like sq_length (len() in Python) now fails with a fatal
error if the slot succeeded with an exception set, or failed with no
exception set.

Check the result of all slots using _Py_CheckSlotResult().
No longer pass op_name to ternary_op() in release mode.
Replace operator with dunder Python method name in error messages.
For example, replace "*" with "mul".
Fix compiler_exit_scope() when an exception is set.
Fix bytearray.extend() when an exception is set: don't call
bytearray_setslice() with an exception set.

https://bugs.python.org/issue42979

When Python is built in debug mode (with C assertions), calling a type slot like sq_length (__len__() in Python) now fails with a fatal error if the slot succeeded with an exception set, or failed with no exception set. The error message contains the slot, the type name, and the current exception (if an exception is set). * Check the result of all slots using _Py_CheckSlotResult(). * No longer pass op_name to ternary_op() in release mode. * Replace operator with dunder Python method name in error messages. For example, replace "*" with "__mul__". * Fix compiler_exit_scope() when an exception is set. * Fix bytearray.extend() when an exception is set: don't call bytearray_setslice() with an exception set.

bedevere-bot · 2021-01-29T11:48:25Z

🤖 New build scheduled with the buildbot fleet by @vstinner for commit a7eb557 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

vstinner · 2021-01-29T11:49:00Z

Replace operator with dunder Python method name in error messages. For example, replace "*" with "mul".

Note for myself: I reverted this change, since the operator was part of some TypeError error messages.

vstinner · 2021-01-29T15:06:09Z

buildbot/AMD64 FreeBSD Shared PR

"3 tests failed again: test_gdb test_subprocess test_venv"

These errors seem to be unrelated to my PR.

vstinner · 2021-01-29T15:52:26Z

I didn't some basic sanity tests and they completed successfully:

create a venv
install cinder and run ./env/bin/python -m cinder.service (I had to fix two minor Python 3.10 issues in eventlet and oslo.context)
pip commands: cache dir, cache info, cache list, freeze, install -U pip

vstinner requested review from markshannon and rhettinger as code owners Jan 28, 2021

the-knights-who-say-ni added the CLA signed label Jan 28, 2021

bedevere-bot added the awaiting core review label Jan 28, 2021

vstinner force-pushed the vstinner:more_slot_assert branch 3 times, most recently from 04c2696 to 5d020bc Jan 28, 2021

vstinner force-pushed the vstinner:more_slot_assert branch from 5d020bc to a7eb557 Jan 29, 2021

vstinner added the 🔨 test-with-buildbots label Jan 29, 2021

bedevere-bot removed the 🔨 test-with-buildbots label Jan 29, 2021

bedevere-bot removed the awaiting core review label Jan 29, 2021

vstinner deleted the vstinner:more_slot_assert branch Jan 29, 2021

python / cpython

bpo-42979: Use _Py_CheckSlotResult() to check slots result #24356

bpo-42979: Use _Py_CheckSlotResult() to check slots result #24356

vstinner commented Jan 28, 2021 •

edited

bedevere-bot commented Jan 29, 2021

vstinner commented Jan 29, 2021

vstinner commented Jan 29, 2021

vstinner commented Jan 29, 2021

python / cpython

Sponsor python/cpython

bpo-42979: Use _Py_CheckSlotResult() to check slots result #24356

bpo-42979: Use _Py_CheckSlotResult() to check slots result #24356

Conversation

vstinner commented Jan 28, 2021 • edited

bedevere-bot commented Jan 29, 2021

vstinner commented Jan 29, 2021

vstinner commented Jan 29, 2021

vstinner commented Jan 29, 2021

vstinner commented Jan 28, 2021 •

edited