Skip to content

bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent#24100

Merged
miss-islington merged 4 commits into
python:masterfrom
yairfrid:Issue42811
Jan 6, 2021
Merged

bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent#24100
miss-islington merged 4 commits into
python:masterfrom
yairfrid:Issue42811

Conversation

@yairfrid

@yairfrid yairfrid commented Jan 4, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42811

Automerge-Triggered-By: GH:brettcannon

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 4, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Fongeme

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 4, 2021
@brettcannon brettcannon self-requested a review January 4, 2021 21:13
brettcannon
brettcannon requested changes Jan 6, 2021
View reviewed changes
Comment thread Doc/library/importlib.rst Outdated
Comment thread Misc/NEWS.d/next/Documentation/2021-01-04-22-14-22.bpo-42811.HY2beA.rst Outdated
@bedevere-bot

bedevere-bot commented Jan 6, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

yairfrid and others added 2 commits January 6, 2021 11:49
@yairfrid @brettcannon
Update Doc/library/importlib.rst
1c017a6 
Use __spec__.parent instead of __spec__

Co-authored-by: Brett Cannon <brett@python.org>
@yairfrid @brettcannon
Update Misc/NEWS.d/next/Documentation/2021-01-04-22-14-22.bpo-42811.H…
723e86b 
…Y2beA.rst


According to last commit

Co-authored-by: Brett Cannon <brett@python.org>
@yairfrid

yairfrid commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 6, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@brettcannon brettcannon changed the title bpo-42811: Update importlib.utils.resolve_name docs bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__.parent Jan 6, 2021
@miss-islington miss-islington merged commit ff8458b into python:master Jan 6, 2021
@miss-islington

miss-islington commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

Thanks @Fongeme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

Sorry @Fongeme, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ff8458b918050168acda1ad6d079f52b8effa821 3.9

@miss-islington miss-islington self-assigned this Jan 6, 2021
@bedevere-bot

bedevere-bot commented Jan 6, 2021

Copy link
Copy Markdown

GH-24144 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2021
@yairfrid @miss-islington
bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__…
6ba503d 
….parent (pythonGH-24100)

Automerge-Triggered-By: GH:brettcannon
(cherry picked from commit ff8458b)

Co-authored-by: Yair Frid <fridyair@gmail.com>
yairfrid added a commit to yairfrid/cpython that referenced this pull request Jan 7, 2021
@yairfrid
[3.9] bpo-42811: Update importlib.utils.resolve_name() docs to use __…
7fcf792 
…spec__.parent (pythonGH-24100)
@yairfrid yairfrid mentioned this pull request Jan 7, 2021
Merged
@bedevere-bot

bedevere-bot commented Jan 7, 2021

Copy link
Copy Markdown

GH-24149 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit that referenced this pull request Jan 7, 2021
@yairfrid
[3.9] bpo-42811: Update importlib.utils.resolve_name() docs to use __…
8c3914a 
…spec__.parent (GH-24100) (GH-24149)

This is a backport of 
#24100

Automerge-Triggered-By: GH:brettcannon
brettcannon pushed a commit that referenced this pull request Jan 7, 2021
@miss-islington @yairfrid
bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__…
ca8e96d 
….parent (GH-24100) (GH-24144)

Automerge-Triggered-By: GH:brettcannon
(cherry picked from commit ff8458b)

Co-authored-by: Yair Frid <fridyair@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@yairfrid @adorilson
bpo-42811: Update importlib.utils.resolve_name() docs to use __spec__…
ef62a7f 
….parent (pythonGH-24100)

Automerge-Triggered-By: GH:brettcannon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yairfrid @the-knights-who-say-ni @bedevere-bot @miss-islington @brettcannon