Skip to content

[3.8] bpo-42508: Keep IDLE running on macOS (GH-23577)#23670

Merged
terryjreedy merged 1 commit into
python:3.8from
miss-islington:backport-57e5113-3.8
Jan 5, 2021
Merged

[3.8] bpo-42508: Keep IDLE running on macOS (GH-23577)#23670
terryjreedy merged 1 commit into
python:3.8from
miss-islington:backport-57e5113-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 7, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Remove obsolete workaround that prevented running files with
shortcuts when using new universal2 installers built on macOS 11.
Ignore buggy 2nd run_module_event call.
(cherry picked from commit 57e5113)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

https://bugs.python.org/issue42508

@terryjreedy @miss-islington
bpo-42508: Keep IDLE running on macOS (pythonGH-23577)
71fd6c6 
Remove obsolete workaround that prevented running files with
shortcuts when using new universal2 installers built on macOS 11.
Ignore buggy 2nd run_module_event call.
(cherry picked from commit 57e5113)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot bedevere-bot mentioned this pull request Dec 7, 2020
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Dec 7, 2020
@miss-islington

miss-islington commented Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy and @ned-deily: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington

miss-islington commented Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy and @ned-deily: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

@terryjreedy and @ned-deily: Status check is done, and it's a success ✅ .

@terryjreedy

terryjreedy commented Dec 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Travis failure is unrelated but I don't know that it should be ignored. I restarted that one test.

# Regenerate Include/graminit.h and Python/graminit.c
# from Grammar/Grammar using pgen
PYTHONPATH=. python3 -m Parser.pgen ./Grammar/Grammar \
	./Grammar/Tokens \
	./Include/graminit.h.new \
	./Python/graminit.c.new
python3 ./Tools/clinic/clinic.py --make --srcdir .
  File "./Tools/clinic/clinic.py", line 1772
    filename_new = f"{filename}.new"
                                   ^
SyntaxError: invalid syntax
Makefile:574: recipe for target 'clinic' failed
make: *** [clinic] Error 1
make: *** Waiting for unfinished jobs....
python3 ./Tools/scripts/update_file.py ./Include/graminit.h ./Include/graminit.h.new
python3 ./Tools/scripts/update_file.py ./Python/graminit.c ./Python/graminit.c.new

@terryjreedy

terryjreedy commented Dec 7, 2020

Copy link
Copy Markdown
Member

Same error on rerun.

@terryjreedy terryjreedy requested review from ambv and ned-deily December 7, 2020 23:11
@terryjreedy

terryjreedy commented Dec 7, 2020

Copy link
Copy Markdown
Member

@ambv @ned-deily If the next 3.8 is going to have a macox11 installer, then this should be merged, (I believe Ned requested the backport.) But I don't know what to do about the repeated failure.

@ned-deily

ned-deily commented Dec 7, 2020

Copy link
Copy Markdown
Member

@terryjreedy, you are not alone in seeing 3.8 CI failures, see https://bugs.python.org/issue42574. At the moment, support for macOS Big Sur / Apple Silicon has not yet been merged to 3.8 and I believe @ambv has decided to release 3.8.7rc1 without it. So this IDLE 3.8 backport is not critical yet, but we should plan on getting it in soon.

@terryjreedy terryjreedy merged commit d05b470 into python:3.8 Jan 5, 2021
@bedevere-bot

bedevere-bot commented Jan 5, 2021

Copy link
Copy Markdown

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-57e5113-3.8 branch January 5, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

@ambv ambv Awaiting requested review from ambv

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @terryjreedy @ned-deily @bedevere-bot @the-knights-who-say-ni