Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42383: pdb: do not fail to restart the target if the current directory changed #23412

Merged
merged 1 commit into from Jan 25, 2021
Merged

bpo-42383: pdb: do not fail to restart the target if the current directory changed #23412

merged 1 commit into from Jan 25, 2021

Conversation

Copy link
Contributor

@hexagonrecursion hexagonrecursion commented Nov 19, 2020

#23338 should be merged first because it contains the actual fix since both https://bugs.python.org/issue42383 and https://bugs.python.org/issue42384 can be fixed by adding one line.

Following this instructions

#23338 (comment)

My personal experience(NOT the official way):

* Creating the first PR to solve the fist issue you want fixed.

* After the first PR merged, we can add some description info in second issue, something like: `After PR-XXX merged, this issue should be resolved by the way.`. MAYBE you can create an another PR to add the testcase of the second issue.

I opened a separate PR for bpo-42383

https://bugs.python.org/issue42383

@github-actions
Copy link

@github-actions github-actions bot commented Dec 20, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 20, 2020
…ctory changed

This commit only adds tests and a news entry. The actual bug was fixed in the earlier commit.
@hexagonrecursion
Copy link
Contributor Author

@hexagonrecursion hexagonrecursion commented Jan 25, 2021

Now that #23338 is merged this can also be merged. #23338 fixed both bpo-42383 and bpo-42384 with a one-line change, but the test for bpo-42383 was split into a separate PR as recommended in #23338 (comment)

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jan 25, 2021

Something's missing -- this just adds a test but doen't change anything in pdb.py.

Copy link
Member

@gvanrossum gvanrossum left a comment

Oh wait that's because the other PR fixed both issues.

Next time I think you should just do everything in one PR. :-)

@gvanrossum gvanrossum removed the stale label Jan 25, 2021
@gvanrossum gvanrossum merged commit 501d4a5 into python:master Jan 25, 2021
11 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 25, 2021

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jan 25, 2021

@hexagonrecursion Is it worth backporting this too?

@hexagonrecursion hexagonrecursion deleted the tests-for-bpo-42383 branch Jan 26, 2021
@hexagonrecursion
Copy link
Contributor Author

@hexagonrecursion hexagonrecursion commented Jan 26, 2021

@hexagonrecursion Is it worth backporting this too?

I already did.

gvanrossum pushed a commit that referenced this issue Jan 26, 2021
gvanrossum pushed a commit that referenced this issue Jan 26, 2021
m000 added a commit to m000/cpython that referenced this issue Jan 29, 2021
…ctory changed (python#23412)

This commit only adds tests and a news entry. The actual bug was fixed in the earlier commit.
adorilson added a commit to adorilson/cpython that referenced this issue Mar 13, 2021
…ctory changed (python#23412)

This commit only adds tests and a news entry. The actual bug was fixed in the earlier commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants