Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Hide resolved comments in changes tree; Indicate resolved comments on margin #2253
Conversation
Use pullRequest/reviewThreads instead of pullRequest/review/comments.
…thread-resolved-status
Only use reviewThreads/isResolved on github.com where they are guaranteed to be available.
e2c2462
to
8e4a5a9
Show, "This conversation was marked as resolved" on peek view when conversation has been marked as resolved.
91b62a2
to
a489f5d
|
I went and did A Thing replacing the info icon with the one built into visual studio. The result is a look and feel closer to a native infobar: Blue Theme! Dark Theme! At first I was concerned about how much it popped out in the Dark Theme even though I was using the background color that we get from Visual Studio. However, I think it's okay for the following reasons:
We've diverged a bit from what I've prototyped but I think that's fine given that my prototype relied heavily on the interaction of collapsing resolved comments. |
I think this is a good call. |
Previously pull request comments would be implicitly resolved when when the text near to the comment was changed. GitHub now supports comments being explicitly resolved by a user and comments becoming implicitly outdated when the text near to the comment is changed.
This pull request surfaces the
IsResolvedstatus of a review comment threads and hides resolved comments from the changes tree (in a similar way to how outdated comments are hidden). This makes it easy to find comments that still need to be addressed when responding to a pull request review.What this PR does
pullRequest/reviewThreadsto populate theIsResolvedstatus of a pull request comment threadsreviewThreadsmight not be available)To do
What this PR doesn't do
How to test
https://github.com/grokys/PullRequestSandboxin Visual StudioGitHubpaneProgram.cs💬 1commentProgram.csappears in diff view and comment is visibleThe conversation was marked as resolvedbanner appears above commentNotes
Here is what is looks like in the
DarkthemeRelated #2245