Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Ensure we only reference System.Net.Http v4.0.0.0 #2191
Conversation
|
Nice touch with the tests there, good job! |
|
LGTM, if this works then we can try dual-targeting Octokit.GraphQL. |
Check all GitHub.* assemblies reference System.Net.Http v4.0.0.0.
0fdfb12
to
9eb18d7
|
@jcansdale @meaghanlewis This PR has fixed it my issues! Thanks! One small nit I noticed, when I clicked on the "Release Notes" link in the VSIX installer, the notes indicated this update would be version 2.7.1, however after installed, Visual Studio shows the version as 2.8.0.xxxx |
|
@jcansdale Not sure it's important, but to narrow the .Net version issue down abit... My issues occurred with .Net Version 4.7.02556 installed. |
I did the initial fix on the master branch (which is now 2.8), but rebased back to 2.7 for the patch release. The
Thanks, this is useful (and worrying) information. The issue will have been more widespread that I expected. Am I correct in thinking you're not using a version of Windows 10 with auto-updates turned on? |
|
I’ll have to look when I get to work tomorrow, but I think my laptop does NOT do auto updates. It is Windows 10 and it’s prettylocked down by my IT Dept. |
|
no worries.
…On Thu, Jan 24, 2019 at 10:28 PM tsimmons1987 ***@***.***> wrote:
I’ll have to look when I get to work tomorrow, but I think my laptop does
NOT do auto updates. It is Windows 10 and it’s prettylocked down by my IT
Dept.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AfEtBhh2en1owHGDnz_m7-Nkujf0SiSnks5vGoflgaJpZM4aMnCJ>
.
|
|
@jcansdale Just to close the loop, I checked and my laptop is set to automatically update, not sure why it didn't update .Net to a version that doesn't exhibit the problem. It could be that my company limits the updates available. Also the auto update of Visual Studio is what caused the issue when I suddenly couldn't open my repos any more. |
NOTE: Can't use extension when only .NET 4.7 or below is installed
What happended
When we changed to include the
Octokit.GraphQLrepository as a submodule in #2127 and reference its projects (rather than referencing it as a NugGet package), this had the unintended consequence of changing which version ofSystem.Net.Httpany consuming projects referenced.For users who have a new version of .NET installed this didn't break anything because there is an automatic binding direct from
System.Net.Http, v4.1.1.0toSystem.Net.Http, v4.0.0.0. Unfortunately users with an older version of .NET installed would experience the following exception:What this PR does
This PR ensures that we reference the
System.Net.Http, v4.0.0.0assembly by changing theOctokit.GraphQLprojects to compile against .NET 4.6 rather than .NET Standard 1.1 as they were before. This is a simple fix that should allow us to get a patch release out ASAP.GitHub.*assemblies only referenceSystem.Net.Http, v4.0.0.0Octokit.GraphQLandOctokit.GraphQL.CoreHow to test
System.Net.Httpassembly.Here is a screenshot of the .vsix contents from this PR:

More detail
On recent versions of .NET there is an automatic redirect from
System.Net.Http, v4.1.1.0tov4.1.1.0. Here is a binding log generated byfuslogvw:Attempting to load
System.Net.Http, v4.1.1.0inside a docker image build frommicrosoft/dotnet-framework:4.6.2-runtimefails.I don't know when exactly this redirect was put in place, but it was somewhere between .NET 4.6.2 and .NET 4.7.2.
Fixes #2190
Fixes #2188
Fixes #2186
Fixes #2185
Fixes #2195