Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42393: Raise OverflowError iso. DeprecationWarning on overflow in socket.ntohs and socket.htons #23980

Merged
merged 6 commits into from Dec 31, 2020
Merged

bpo-42393: Raise OverflowError iso. DeprecationWarning on overflow in socket.ntohs and socket.htons #23980

merged 6 commits into from Dec 31, 2020

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 28, 2020 •
edited by bedevere-bot

@erlend-aasland
Copy link
Author

@erlend-aasland erlend-aasland commented Dec 28, 2020

@serhiy-storchaka, would you mind reviewing this?

serhiy-storchaka
serhiy-storchaka reviewed Dec 29, 2020
View changes
Modules/socketmodule.c Outdated Show resolved Hide resolved
Doc/library/socket.rst Show resolved Hide resolved
Doc/library/socket.rst Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Author

@erlend-aasland erlend-aasland commented Dec 29, 2020 •
edited

Thank you for reviewing, @serhiy-storchaka. PTAL.

@serhiy-storchaka serhiy-storchaka merged commit f4936ad into python:master Dec 31, 2020
11 checks passed
@erlend-aasland erlend-aasland deleted the bpo-42393 branch Dec 31, 2020
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 13, 2021
@erlend-aasland @adorilson
bpo-42393: Raise OverflowError iso. DeprecationWarning on overflow in…
d5a1eb6 
… socket.ntohs and socket.htons (pythonGH-23980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot