Skip to content

Fix compiler warnings regarding loss of data #23983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Dec 29, 2020
Merged

Fix compiler warnings regarding loss of data #23983

pablogsal merged 1 commit into from
Dec 29, 2020
+2 −2

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 29, 2020 

'initializing': conversion from 'Py_ssize_t' to 'int', possible loss of data [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj]

'initializing': conversion from 'double' to 'int', possible loss of data [D:\a\cpython\cpython\PCbuild\_sqlite3.vcxproj]

@pablogsal pablogsal merged commit a6d63a2 into python:master Dec 29, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the Py_ssize_t branch December 29, 2020 00:28
@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a6d63a20df63b3fd33b5e1f629e7f96d00f6ae39 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a6d63a20df63b3fd33b5e1f629e7f96d00f6ae39 3.8

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
Fix compiler warnings regarding loss of data (pythonGH-23983)
8c9e3fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

@pablogsal pablogsal

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @miss-islington @the-knights-who-say-ni @bedevere-bot