Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix missing commas in signatures #23693

Merged
merged 2 commits into from Dec 22, 2020

Conversation

@andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Dec 8, 2020

No description provided.

@andresdelfino andresdelfino changed the title [doc] Fix star in datetime signatures [doc] Fix missing commas Dec 8, 2020
@andresdelfino andresdelfino changed the title [doc] Fix missing commas [doc] Fix missing commas in signatures Dec 8, 2020
@andresdelfino andresdelfino requested a review from python/email-team as a code owner Dec 8, 2020
@andresdelfino
Copy link
Contributor Author

@andresdelfino andresdelfino commented Dec 22, 2020

@pganssle perhaps this can be merged?

@pganssle
Copy link
Member

@pganssle pganssle commented Dec 22, 2020

@andresdelfino Oh sorry, I noticed that you were a "Member" of the Python org and assumed you had a commit bit so I figured you'd merge yourself, but now I see that triagers also show up as "Member". My mistake!

Merging now. Thanks!

@pganssle pganssle merged commit 60eccd0 into python:master Dec 22, 2020
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201208.19 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 22, 2020

@pganssle: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 22, 2020

Thanks @andresdelfino for the PR, and @pganssle for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 22, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 22, 2020

GH-23891 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 22, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 22, 2020

GH-23892 is a backport of this pull request to the 3.8 branch.

@andresdelfino andresdelfino deleted the andresdelfino:fix_star_signatures branch Dec 22, 2020
miss-islington added a commit that referenced this pull request Dec 29, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Dec 29, 2020
* Fix star in signatures

* Fix comma in signatures
(cherry picked from commit 60eccd0)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants