Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate devguide to python-docs-theme #351

Closed
willingc opened this issue Mar 25, 2018 · 6 comments
Closed

Migrate devguide to python-docs-theme #351

willingc opened this issue Mar 25, 2018 · 6 comments
Labels
enhancement

Comments

@willingc
Copy link
Collaborator

@willingc willingc commented Mar 25, 2018 •
edited by Mariatta

For maintainability and consistency, migrating to https://github.com/python/python-docs-theme makes good sense.

fyi @ned-deily @jonparrott
@theacodes theacodes mentioned this issue Mar 28, 2018
Merged
@zware
Copy link
Member

@zware zware commented Mar 29, 2018

We did lose our explicitly-different-from-docs.python.org top bar color.
@Mariatta
Copy link
Member

@Mariatta Mariatta commented Mar 29, 2018

Sorry I missed that :(
@jonparrott is the top bar color something can be configured for devguide? Thanks.
@Mariatta Mariatta reopened this Mar 29, 2018
@theacodes
Copy link
Contributor

@theacodes theacodes commented Mar 29, 2018

What color should it be?
@zware
Copy link
Member

@zware zware commented Mar 29, 2018

#6BA81E

I'm not sure whether we also had to change text colors to go along with that.
@theacodes
Copy link
Contributor

@theacodes theacodes commented Mar 29, 2018

okay, I'll see what I can do.
@willingc
Copy link
Collaborator Author

@willingc willingc commented Mar 29, 2018

We should be able to set custom.css in the devguide to adjust colors as needed. Thanks @jonparrott. Please let me know if you hit a snag.
@theacodes theacodes mentioned this issue Mar 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@theacodes @willingc @Mariatta @zware
You can’t perform that action at this time.