Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude GitHub.TeamFoundation.14 Asset from VS2017 #1705

Merged
merged 2 commits into from Jun 18, 2018
Merged

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented May 23, 2018

What this PR does

Clean up MEF log when extension installed in Visual Studio 2017

  • Use TargetVersion="[14.0,15.0)" to exclude GitHub.TeamFoundation.14
    MEF component from VS2017

The source.extension.vsixmanifest now includes this:

    <Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" 
        d:ProjectName="GitHub.TeamFoundation.14"
        TargetVersion="[14.0,15.0)" Path="|GitHub.TeamFoundation.14|" />
    <Asset Type="Microsoft.VisualStudio.MefComponent" 
        d:Source="Project" d:ProjectName="GitHub.TeamFoundation.15"
        TargetVersion="[15.0,16.0)" Path="|GitHub.TeamFoundation.15|" />

Unfortunately the TargetVersion="[15.0,16.0)" won't be understood by Visual Studio 2015 (so its MEF log will remain dirty).

How to test

Install in Visual Studio 2017 and use the Clear MEF Component Cache extension to Show MEF Errors (it's on the Tools menu). This should now be empty in Visual Studio 2017.

Errors will still appear in Visual Studio 2015 (it doesn't support the TargetVersion attribute).

Fixes #1704

Use `TargetVersion="[14.0,15.0)"` to exclude `GitHub.TeamFoundation.14`
MEF component Asset from VS2017.
@grokys
grokys approved these changes Jun 18, 2018
Copy link
Contributor

@grokys grokys left a comment

Seems to work for me!

@grokys grokys merged commit a83ebfe into github:master Jun 18, 2018
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@meaghanlewis meaghanlewis added this to the 2.5.3 milestone Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.