Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow inline comment peek view to resize to content. #1112
Merged
Conversation
|
This is definitely working better than before. Can be a bit glitchy with over-sized comment lists (when the top of the peek view goes off screen), but I understand this could be tricky to fix. It's certainly an improvement for most cases. I like how it handles the comment box being expanded as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This allows the inline comment peek view to size itself according to the amount of content in the thread.
It also fixes the scrolling issue we previously had with the peek view where scrollwheel messages weren't passed up to the editor when the peek view was fully scrolled.