Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
WIP: Spike of Pull Request Reviews feature. #1415
Conversation
`PullRequestDetailView` was not displaying in the Visual Studio designer - it was showing an error related to `OcticonImage`. Not sure why this works when the previous didn't, but seems to fix it.
Display an overview of the current reviews in the PR details pane.
Need to make sure we match the start and end of the string.
We're now implementing diffing and opening files at the view model level in `GitHub.App`. I'm conflicted on whether this is the best place to do this, but it's the easiest way for now.
...to GitHub.Exports
Just the view so far, doesn't really do much.
Hit a snag here: the REST API doesn't allow us to add comments to pending reviews, so instead of creating a pending review we just store everything in memory for now. Submitting reviews not yet implemented.
I'm not sure how this was working...
Also move the changed files into a tab control.
Include outdated comments in comment count. Should we do this? Not sure, but this is how we're counting them in the PR details view.
|
I've been dogfooding this PR the last couple of days. When returning to a PR, the first thing I want to see is whether there are any new reviews/approvals. With the current layout, you need to scroll down past the PR description to find this information. The concise I think it would work better if the
That way is would be easy to see the status of a PR, navigate to the commands and find the In a similar vein, maybe the
|
|
No scrollbar appears on the comments view when it becomes too tall. See other PR comment here: Looking good. |
It was part of the unfinished "PR conversation view" feature.
Instead of starting a new review by clicking on the "Start a review" link in the PR details, start a review in the same way as .com by clicking a "Start a review" button in an inline comment view.
And migrated some unit tests over.
Conflicts: src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs src/GitHub.InlineReviews/Commands/NextInlineCommentCommand.cs src/GitHub.InlineReviews/Commands/PreviousInlineCommentCommand.cs src/GitHub.InlineReviews/InlineReviewsPackage.cs src/GitHub.VisualStudio/Views/GitHubPane/PullRequestDetailView.xaml.cs test/UnitTests/packages.config
Update the header for pull request description
Ported from #1415. Moves the PR details changed files tree into its own view so that it can be shared by the PR reviews view.
Ported from #1415. Moves the PR details changed files tree into its own view so that it can be shared by the PR reviews view.
plus fix a few other spacing opportunities
When authoring a review
Fix a few theming issues
|
Superseded by #1491. |
The PR adds an initial spike of the Pull Request Reviews feature.
Existing reviews are displayed in the PR details pane, filtered to the most recent (non-dismissed, non-pending) review for each user:
Clicking on the review opens a new pane:
Clicking on "Start a review" similarly opens a new pane for authoring a new review:
Known Issues
This is an initial spike of the feature, and as such there are limitations and known issues:
The GitHub REST API does not support modifying pending reviews. This means:If you've already started a review of the PR on GitHub, don't try to do a review on the same PR here. It will breakWe have to keep a record of the line comments for the current review locally. These aren't serialized currently, so closing the solution/VS will mean you lose your commentsFixed: now using GraphQLMoving forward
We need to decide whether to continue storing the state of a pending review locally, or move to GraphQL which supports updating a pending reviewI've gone with GraphQLDepends on #1445