Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the VSGitExt service #1513

Merged

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Mar 2, 2018

  • Use UIContext.WhenActivated instead of UIContext.UIContextChanged event
  • Don't use async InitializeAsync now we're initializing on background thread
  • No more need to call RefreshActiveRepositories using ContinueWith
@jcansdale jcansdale requested a review from grokys Mar 2, 2018
- Use `UIContext.WhenActivated` instead of UIContext.UIContextChanged event
- Don't use async InitializeAsync now we're initializing on background thread
- No more need to use ContinueWith
@jcansdale jcansdale force-pushed the refactor/simplify-VSGitExt branch from 0ed135e to ee9ab4a Mar 2, 2018
@jcansdale jcansdale mentioned this pull request Mar 2, 2018
8 of 9 tasks complete
@jcansdale jcansdale merged commit 0eadf70 into refactor/convert-VSGitExt-to-service Mar 2, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jcansdale jcansdale deleted the refactor/simplify-VSGitExt branch Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.