Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I18n pull request restore with CrowdIn support #1888
Conversation
|
Merged #1871 into this branch, but it appears that the |
| - source: /src/**/Resources.en-US.resx | ||
| translation: /%original_path%/Resources.%locale%.resx | ||
| - source: /src/**/VSPackage.en-US.resx | ||
| translation: /%original_path%/VSPackage.%locale%.resx |
shana
Sep 6, 2018
Collaborator
I wouldn't do this one right now. This is information that's merged with the package for the marketplace and the extension list, not for the VS UI itself.
I wouldn't do this one right now. This is information that's merged with the package for the marketplace and the extension list, not for the VS UI itself.
| - source: /src/**/VSPackage.en-US.resx | ||
| translation: /%original_path%/VSPackage.%locale%.resx | ||
| - source: /src/**/OcticonPaths.en-US.resx | ||
| translation: /%original_path%/OcticonPaths.%locale%.resx |
shana
Sep 6, 2018
Collaborator
There is nothing to translate on this, these are icons in svg format.
There is nothing to translate on this, these are icons in svg format.
|
@maikebing could take a look at this and tell me if I've got anything wrong? |
And move hard-coded UI strings to resources. Co-Authored-By: MysticBoy <mysticboy@live.com>
|
Looking good! Just a suggestion about how we could handle resources in |
.../GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs
Show resolved
Hide resolved
.../GitHub.VisualStudio.UnitTests/Commands/OpenFromClipboardCommandTests.cs
Show resolved
Hide resolved
| @@ -126,9 +146,13 @@ public async Task NoChangesInWorkingDirectory() | |||
| vsServices.DidNotReceiveWithAnyArgs().ShowMessageBoxInfo(null); | |||
| gitHubContextService.Received(1).TryOpenFile(repositoryDir, context); | |||
| } | |||
| [Test] | |||
jcansdale
Sep 11, 2018
Collaborator
Missing CR
Missing CR
Resolve resources that start with a "#" using ResolveResources.
|
All good. |
|
Approve. |
|
Looking good! |
|
Where are the resources specified to be satellites? |
|
@StanleyGoldman the non- |
This PR restores parts of #1714 and adds initial integration with CrowdIn.
It is currently only providing translations in
zn-CHfor our.resxfiles. We're going to need a more scalable solution than duplicating the entirety of our.vsctfiles for every language so those files are going to be tackled in a separate PR.The neutral language
en-USresources are being stored directly in the assemblies themselves with satellite assemblies only being used for translations. This is because WPF does not work well with satellite assemblies for the neutral language.