Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Revert pull request #1714 #1872
Merged
Conversation
|
LGTM |
StanleyGoldman
added a commit
that referenced
this pull request
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
After testing #1714 was shown to cause problems with the extension. Although we think these problems should be fixed by #1871, we've decided that we need more time for testing.
We're reverting #1714 for now, but this PR will make it into our next release after we can be certain that it's not caused other issues.
Pinging @maikebing for visibility - thanks! Your work is really appreciated and we'll make sure to get it into the next release, we just need a little more time :)