Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing and Implementing Autocompletebox #2158

Merged
merged 74 commits into from Apr 10, 2019

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jan 4, 2019

This pull request is the set of changes made to make AutoCompleteBox functional in our codebase

  • Using modern structures like Guard instead of Ensure
  • Removing the legacy cache system
  • Using GraphQL for querying data

Depends On

  • #2159 being merged to this pull request
This reverts commit 653cc79.
@meaghanlewis meaghanlewis mentioned this pull request Jan 15, 2019
7 of 15 tasks complete
# Conflicts:
#	src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml
…letebox-theme
…letebox-theme
Theme the auto complete box
Implementing Autocompletebox
@StanleyGoldman StanleyGoldman changed the title [WIP] Modernizing Autocompletebox Modernizing and Implementing Autocompletebox Apr 8, 2019
…t review and conversation view comments
@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Apr 8, 2019

@StanleyGoldman would it be possible to also show pull requests in the autocomplete list in addition to issues?

@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Apr 10, 2019

@StanleyGoldman this is working well! One thing that differs from dotcom is that you only seem to filter on open issues/PRs (filter = $"repo:{owner}/{name} is:open";) where dotcom shows all.

Copy link
Contributor

@meaghanlewis meaghanlewis left a comment

This functionality works well for me. 👍

@StanleyGoldman StanleyGoldman merged commit 0b5badb into autocompletebox Apr 10, 2019
2 of 3 checks passed
2 of 3 checks passed
github.VisualStudio Build #20190410.8 failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@StanleyGoldman StanleyGoldman deleted the autocompletebox-fix branch Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.