Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fixing validation display on Create Repository dialog #2308
Conversation
| @@ -107,17 +107,21 @@ | |||
| Grid.Column="1" | |||
| MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}" | |||
| Text="{Binding RepositoryName, UpdateSourceTrigger=PropertyChanged}" | |||
| SpellCheck.IsEnabled="True" | |||
jcansdale
Apr 5, 2019
Collaborator
It looks like spell checking has been disabled. Was this by design?
It looks like spell checking has been disabled. Was this by design?
StanleyGoldman
Apr 5, 2019
Author
Contributor
Yea, I disabled it, when I couldn't type VisualStudio without it calling that an error, I decided that it was not useful...
Yea, I disabled it, when I couldn't type VisualStudio without it calling that an error, I decided that it was not useful...
jcansdale
Apr 5, 2019
Collaborator
Lol, makes sense. Though I'm perfectly capable of misspelling the name of my repo. 😉
Lol, makes sense. Though I'm perfectly capable of misspelling the name of my repo.
jcansdale
Apr 5, 2019
Collaborator
It look like dotcom also has spell checking disabled fro this field.
It look like dotcom also has spell checking disabled fro this field.
|
Added screenshots |
|
Looks good. I tested with the dark theme... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Related #2264
Depends on: