bpo-12800: tarfile: Restore fix from 011525ee9 #21409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and re-opening to restart the Travis-CI check. |
This was referenced Sep 19, 2020
Closed
taleinat
reviewed
Sep 19, 2020
| @@ -2232,6 +2232,8 @@ def makelink(self, tarinfo, targetpath): | |||
| try: | |||
| # For systems that support symbolic and hard links. | |||
| if tarinfo.issym(): | |||
| if os.path.lexists(targetpath): | |||
There was a problem hiding this comment.
@JulienPalard, perhaps include a short comment here explaining why this is needed? Something along the lines of "tar should overwrite existing files with symlinks, but os.symlink raises an exception rather than overwriting."
taleinat
approved these changes
Sep 19, 2020
|
Thanks @JulienPalard for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 25, 2020
|
GH-23508 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 25, 2020
|
GH-23509 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 25, 2020
miss-islington
added a commit
that referenced
this pull request
Nov 25, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Restore fix from 011525e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
While reviewing #20972 I spotted the code already existed, the test already existed, but was not seeing the error due to:
https://bugs.python.org/issue12800