Skip to content

C++/C#/JS/Python/Java XML.qll: Remove abstract from class hierarchy.#4727

Merged
jbj merged 2 commits intogithub:mainfrom
criemen:remove-abstract-classes
Nov 27, 2020
Merged

C++/C#/JS/Python/Java XML.qll: Remove abstract from class hierarchy.#4727
jbj merged 2 commits intogithub:mainfrom
criemen:remove-abstract-classes

Conversation

@criemen
Copy link
Collaborator

@criemen criemen commented Nov 25, 2020

@criemen criemen requested review from a team as code owners November 25, 2020 16:23
@criemen criemen changed the title XML.qll: Remove abstract from class hierarchy. C++/C#/JS/Python/Java XML.qll: Remove abstract from class hierarchy. Nov 25, 2020
hvitved
hvitved previously approved these changes Nov 25, 2020
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

MathiasVP
MathiasVP previously approved these changes Nov 25, 2020
@criemen criemen dismissed stale reviews from MathiasVP and hvitved via 3bfb398 November 25, 2020 17:20
@aschackmull
Copy link
Contributor

I wonder why @file is an @xmllocatable, otherwise we could just use that.

@hvitved
Copy link
Contributor

hvitved commented Nov 26, 2020

I wonder why @file is an @xmllocatable, otherwise we could just use that.

Yeah, me too.

@jbj jbj merged commit ad4b2be into github:main Nov 27, 2020
@criemen criemen deleted the remove-abstract-classes branch November 27, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants