Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40521: Make list free list per-interpreter #20642

Merged
merged 1 commit into from Jun 5, 2020
Merged

bpo-40521: Make list free list per-interpreter #20642

merged 1 commit into from Jun 5, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 4, 2020 •
edited by bedevere-bot

Each interpreter now has its own list free list:

  • Move list numfree and free_list into PyInterpreterState.
  • Add _Py_list_state structure.
  • Add tstate parameter to _PyList_ClearFreeList()
    and _PyList_Fini().
  • Remove "#ifdef EXPERIMENTAL_ISOLATED_SUBINTERPRETERS".
  • _PyGC_Fini() clears gcstate->garbage list which can be stored in
    the list free list. Call _PyGC_Fini() before _PyList_Fini() to
    prevent leaking this list.

https://bugs.python.org/issue40521

@vstinner
bpo-40521: Make list free list per-interpreter
4b7acce 
Each interpreter now has its own list free list:

* Move list numfree and free_list into PyInterpreterState.
* Add _Py_list_state structure.
* Add tstate parameter to _PyList_ClearFreeList()
  and _PyList_Fini().
* Remove "#ifdef EXPERIMENTAL_ISOLATED_SUBINTERPRETERS".
* _PyGC_Fini() clears gcstate->garbage list which can be stored in
  the list free list. Call _PyGC_Fini() before _PyList_Fini() to
  prevent leaking this list.
@vstinner vstinner requested a review from pablogsal as a code owner Jun 4, 2020
@vstinner
Copy link
Member Author

vstinner commented Jun 4, 2020

Thanks to "./python -m test -j0 -R 3:3 test_capi test__xxsubinterpreters test_atexit test_threading", I found a leak. It's fixed as part of this PR: "Call _PyGC_Fini() before _PyList_Fini()".

@vstinner vstinner merged commit 88ec919 into python:master Jun 5, 2020
4 checks passed
@vstinner vstinner deleted the list_free_list branch Jun 5, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@vstinner @arun-mani-j
bpo-40521: Make list free list per-interpreter (pythonGH-20642)
91fa778 
Each interpreter now has its own list free list:

* Move list numfree and free_list into PyInterpreterState.
* Add _Py_list_state structure.
* Add tstate parameter to _PyList_ClearFreeList()
  and _PyList_Fini().
* Remove "#ifdef EXPERIMENTAL_ISOLATED_SUBINTERPRETERS".
* _PyGC_Fini() clears gcstate->garbage list which can be stored in
  the list free list. Call _PyGC_Fini() before _PyList_Fini() to
  prevent leaking this list.
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot