Conversation
mislav
left a comment
There was a problem hiding this comment.
Thanks for adding this! <3
mislav
left a comment
There was a problem hiding this comment.
I see now that Winget doesn't yet have the update command, so we can't add the upgrade instructions.
I think this might be a deal-breaker for adding Winget installation instructions to our README, because we don't want to point our users toward an installation method that does not provide them with regular updates.
Let me discuss this with my team. Thank you for your edits so far ❤️
|
I think just because we can install gh using WinGet, we SHOULD add WinGet to the README That's what I think. The final decision is up to GitHub CLI Team |
I was going to create an issue for gh to have a built-in update mechanism. It will also help users who install it using the .msi |
|
@alannt777 See #166 for our previous discussions about a built-in update mechanism. We haven't decided yet whether we want to go in that direction. |
|
This is kinda but not really RELATED to this PR but still: I initially installed gh using the msi and when 1.1.0 was released, it was a hassle to upgrade to 1.1.0. Yes, that's exactly why you would use a package manager but not everyone uses a package manager (especially Windows users). Please implement a build-in upgrade option for those people like me who uses WinGet |
|
@alannt777 I personally do agree that a built-in upgrade mechanism is the best experience for users like you. So I do completely understand your viewpoint. The main reason we haven't built it is because an updater mechanism is non-trivial to build and have it run the same on different platforms. |
|
i mean tecnically you can just run the winget install command again to get updates |
|
Maybe yes, but what about those who installed from the msi? |
|
it's supposed to work fine, winget just downloads and execute the msi |
|
If that's true, then I don't see why we wouldn't want to mention WinGet as install option in the README |
Nice point, @LuanVSO! I didn't even think of that working. @alannt777 Could you then add upgrade instructions (like the 2-column table for other installation methods) where the upgrade method is also |
|
@mislav install command seems not to work all the time see microsoft/winget-cli#654 |
|
@alannt777 Thanks for reporting. What is the conclusion from the other thread? Please send a PR to update our instructions if needed. 🙇 |
|
@mislav I tried to use the install command to upgrade to the latest version of gh and it worked! It turns out that the guy tried to install before the manifest for the latest version was merged into the winget-pkgs repo. The problem is the large time difference between gh reporting a new version and the availability of the manifest in the winget manifest repo |
|
Nothing to worry about. It works like a charm: |





Closes #2268
Winget is not mentioned in the README as an install option
This PR fixes this issue