Skip to content

Mention winget as an install option in README#2272

Merged
mislav merged 5 commits into
trunkfrom
unknown repository
Oct 28, 2020
Merged

Mention winget as an install option in README#2272
mislav merged 5 commits into
trunkfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 23, 2020

Copy link
Copy Markdown

Closes #2268

Winget is not mentioned in the README as an install option

This PR fixes this issue

Comment thread README.md Outdated
@ghost ghost requested a review from samcoe October 26, 2020 11:03

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! <3

Comment thread README.md Outdated
@ghost ghost requested a review from mislav October 26, 2020 11:39

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that Winget doesn't yet have the update command, so we can't add the upgrade instructions.

I think this might be a deal-breaker for adding Winget installation instructions to our README, because we don't want to point our users toward an installation method that does not provide them with regular updates.

Let me discuss this with my team. Thank you for your edits so far ❤️

@ghost

ghost commented Oct 26, 2020

Copy link
Copy Markdown
Author

I think just because we can install gh using WinGet, we SHOULD add WinGet to the README

That's what I think. The final decision is up to GitHub CLI Team

@ghost

ghost commented Oct 26, 2020

Copy link
Copy Markdown
Author

... installation method that does not provide them with regular updates

I was going to create an issue for gh to have a built-in update mechanism. It will also help users who install it using the .msi

@mislav

mislav commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

@alannt777 See #166 for our previous discussions about a built-in update mechanism. We haven't decided yet whether we want to go in that direction.

@ghost

ghost commented Oct 26, 2020

Copy link
Copy Markdown
Author

This is kinda but not really RELATED to this PR but still:

I initially installed gh using the msi and when 1.1.0 was released, it was a hassle to upgrade to 1.1.0. Yes, that's exactly why you would use a package manager but not everyone uses a package manager (especially Windows users). Please implement a build-in upgrade option for those people like me who uses WinGet

@mislav

mislav commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

@alannt777 I personally do agree that a built-in upgrade mechanism is the best experience for users like you. So I do completely understand your viewpoint. The main reason we haven't built it is because an updater mechanism is non-trivial to build and have it run the same on different platforms.

@LuanVSO

LuanVSO commented Oct 27, 2020

Copy link
Copy Markdown

i mean tecnically you can just run the winget install command again to get updates

@ghost

ghost commented Oct 27, 2020

Copy link
Copy Markdown
Author

@LuanVSO

Maybe yes, but what about those who installed from the msi?

@LuanVSO

LuanVSO commented Oct 27, 2020

Copy link
Copy Markdown

it's supposed to work fine, winget just downloads and execute the msi

@ghost

ghost commented Oct 27, 2020

Copy link
Copy Markdown
Author

If that's true, then I don't see why we wouldn't want to mention WinGet as install option in the README

@mislav

mislav commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

i mean tecnically you can just run the winget install command again to get updates

Nice point, @LuanVSO! I didn't even think of that working.

@alannt777 Could you then add upgrade instructions (like the 2-column table for other installation methods) where the upgrade method is also winget install gh? I realize that winget install gh will then be repeated twice, but I think it's better to be explicit (and consistent). Thank you!

@ghost

ghost commented Oct 28, 2020

Copy link
Copy Markdown
Author

I was using gh:

image

I tried:

image

and:

image

image

The installer even said that it was removing the older versions of the program!

Comment thread README.md Outdated
@ghost ghost requested a review from mislav October 28, 2020 06:46

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghost

ghost commented Nov 28, 2020

Copy link
Copy Markdown
Author

@mislav install command seems not to work all the time see microsoft/winget-cli#654

@mislav

mislav commented Nov 30, 2020

Copy link
Copy Markdown
Contributor

@alannt777 Thanks for reporting. What is the conclusion from the other thread? Please send a PR to update our instructions if needed. 🙇

@ghost

ghost commented Nov 30, 2020

Copy link
Copy Markdown
Author

@mislav I tried to use the install command to upgrade to the latest version of gh and it worked!

It turns out that the guy tried to install before the manifest for the latest version was merged into the winget-pkgs repo. The problem is the large time difference between gh reporting a new version and the availability of the manifest in the winget manifest repo

@ghost

ghost commented Dec 4, 2020

Copy link
Copy Markdown
Author

@mislav

Nothing to worry about. It works like a charm:

Installer does its magic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WinGet as an install option in README

3 participants