Skip to content

/ libgit2sharp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK version in global.json #1784

Merged
merged 1 commit into from Apr 15, 2020
Merged

Update SDK version in global.json #1784

merged 1 commit into from Apr 15, 2020

Conversation

@bording
Copy link
Member

@bording bording commented Apr 15, 2020 •
edited

The new SDK is required to work with the 16.5 version of Visual Studio 2019.

Fixes #1781
@bording
Update SDK version in global.json
Verified
This commit was signed with a verified signature.
bording Brandon Ording
GPG key ID: FA5A63FFCAA40219 Learn about signing commits
Loading status checks…
8671cc7
@bording bording merged commit 7fc4be5 into master Apr 15, 2020
6 checks passed
6 checks passed
libgit2sharp Build #0.27.0-preview.55+5785b7e612.libgit2-6777db8 succeeded
Details
libgit2sharp (Linux) Linux succeeded
Details
libgit2sharp (Windows) Windows succeeded
Details
libgit2sharp (WrapUp) WrapUp succeeded
Details
libgit2sharp (leak_check) leak_check succeeded
Details
libgit2sharp (macOS) macOS succeeded
Details
@bording bording deleted the update-global-json branch Apr 15, 2020
@AArnott
Copy link
Contributor

@AArnott AArnott commented Apr 15, 2020

I don't object to updating global.json to keep up with the current SDK, but I disagree that VS requires it.

I have VS 16.7 on my box and it loads all the projects just fine. So I don't think we can claim this fixes #1781. If it's the case that we somehow need the 32-bit version of the SDK installed, that might need a different fix.
@bording
Copy link
Member Author

@bording bording commented Apr 15, 2020

If it's the case that we somehow need the 32-bit version of the SDK installed, that might need a different fix.

It's my understanding that VS does not care about the 32-bit SDK. It installs the 64-bit SDK when you install the .NET Core workload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Can't load projects in solution
2 participants
@bording @AArnott
You can’t perform that action at this time.