Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild.ps1/build_helpers.ps1 issues #169
Comments
|
Realized I missed a minor detail: Originally: $x = $_ -replace '^(\s*)(Expected)(.*)\s(to equal .*)','$1$2$3%%$1$4'
$x.Replace('%%',"`n ") I replaced with: $_ -replace '^(\s*)(Expected.*?)\s(instead found .*)', "`$1`$2`n`$1`$3"I missed the two spaces following the |
Issue Description
build.ps1
EditorSyntax/build.ps1
Line 10 in cf27d6e
[cmdletbinding()]and[parameter()]attributes are unnecessary.EditorSyntax/build.ps1
Lines 28 to 33 in cf27d6e
&(call operator) to execute commands with an unquoted (and non-expanded) name are unnecessary. (3 occurrences total)EditorSyntax/build.ps1
Line 41 in cf27d6e
tools\build_helpers.ps1
function ExtractAtom
$PSScriptRootandResolve-Pathwill format with thefilesystem::provider, which notation is not acceptable to[System.IO.Compression.ZipFile]::ExtractToDirectory()method. This is informational only, due to the fact that UNC paths do not work for NPM anyway.function ParseJasmine
EditorSyntax/tools/build-helpers.ps1
Lines 38 to 56 in cf27d6e
$stringparameter, the rest use$_. Surprisingly it works, but only because inRunSpecsthe call toParseJasmineis part of aForEach-Objectwhich populates the$_automatic variable.^\s+Expectedreplacement doesn't seem to be working correctly. Maybe Atom/Atom-Grammar-Test has changed? I think 'to equal' now is to be 'instead found'.RunSpecs:EditorSyntax/tools/build-helpers.ps1
Line 73 in cf27d6e
to read more like:
function RunSpecs
$script:ATOM_EXE_PATHare unneeded, probably old habit from CMD or another shell? (seen below)$specpathin a test previously. Only issue with using the variable is a chance to get the PowerShellfilesystem::provider notation injected.EditorSyntax/tools/build-helpers.ps1
Lines 72 to 73 in cf27d6e
I'll post a PR shortly demonstrating these changes.