💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

• fix: don't overwrite prevent_default if default wasn't prevented
• feat: add app.isPackaged() method
• docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

• Follow the JavaScript, C++, and Python coding style.
• Run npm run lint locally to catch formatting errors earlier.
• Document any user-facing changes you've made following the documentation styleguide.
• Include tests when adding/changing behavior.
• Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

also, we could probably use production mode instead of development with TerserPlugin and manually disabled source mapping. unless there's a reason for that?

also, we could probably use production mode instead of development with TerserPlugin and manually disabled source mapping. unless there's a reason for that?

I honestly don't remember why I did that, I think it's because initially we didn't have the minifier. Then we relealized it made everything faster 😆

As long as we can keep our custom terser settings then production mode might make sense here

As long as we can keep our custom terser settings then production mode might make sense here

I'd rather do it in a separate PR, it does add some more things than just the already-overridden settings:

Sets process.env.NODE_ENV on DefinePlugin to value production. Enables FlagDependencyUsagePlugin,
FlagIncludedChunksPlugin, ModuleConcatenationPlugin, NoEmitOnErrorsPlugin, OccurrenceOrderPlugin,
SideEffectsFlagPlugin and TerserPlugin.
https://webpack.js.org/configuration/mode/

Also, is there a way to re-trigger the build-mac workflow? I'm think it might have just randomly timed out?

Congrats on merging your first pull request! 🎉🎉🎉

No Release Notes