Skip to content

/ electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix build with enable_pdf_viewer=false #25494

Merged
merged 1 commit into from Sep 16, 2020
Merged

build: fix build with enable_pdf_viewer=false #25494

merged 1 commit into from Sep 16, 2020

Conversation

@miniak
Copy link
Contributor

@miniak miniak commented Sep 16, 2020 •
edited by alexeykuzmin

Description of Change

Fix build with enable_pdf_viewer=false.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: none
@miniak
build: fix build with enable_pdf_viewer=false
Loading status checks…
21d2376
@miniak miniak marked this pull request as ready for review Sep 16, 2020
@nornagon
nornagon approved these changes Sep 16, 2020
View changes
@codebytere codebytere mentioned this pull request Sep 16, 2020
Closed
3 of 4 tasks complete
@codebytere
codebytere approved these changes Sep 16, 2020
View changes
@alexeykuzmin
alexeykuzmin approved these changes Sep 16, 2020
View changes
@alexeykuzmin alexeykuzmin merged commit e0a25cb into master Sep 16, 2020
18 checks passed
18 checks passed
Backportable? - 10-x-y Backport Failed
Details
Backportable? - 9-x-y Backport Failed
Details
Artifact Comparison No Changes
Details
Backportable? - 11-x-y Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200916.19 succeeded
Details
electron-arm64-testing Build #20200916.19 succeeded
Details
electron-woa-testing Build #20200916.16 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 16, 2020

No Release Notes
@alexeykuzmin alexeykuzmin deleted the miniak/enable_pdf_viewer branch Sep 16, 2020
@trop
Copy link
Contributor

@trop trop bot commented Sep 16, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.
@trop trop bot removed the target/10-x-y label Sep 16, 2020
@trop
Copy link
Contributor

@trop trop bot commented Sep 16, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.
@trop trop bot mentioned this pull request Sep 16, 2020
Merged
@trop
Copy link
Contributor

@trop trop bot commented Sep 16, 2020

I have automatically backported this PR to "11-x-y", please check out #25507
@trop trop bot added in-flight/11-x-y and removed target/11-x-y labels Sep 16, 2020
miniak added a commit that referenced this pull request Sep 16, 2020
@miniak Milan Burda
build: fix build with enable_pdf_viewer=false (#25494)
Loading status checks…
e156999
@miniak miniak mentioned this pull request Sep 16, 2020
Merged
@trop
Copy link
Contributor

@trop trop bot commented Sep 16, 2020

@miniak has manually backported this PR to "10-x-y", please check out #25508
miniak added a commit that referenced this pull request Sep 17, 2020
@miniak Milan Burda
build: fix build with enable_pdf_viewer=false (#25494)
Loading status checks…
893c777
@miniak miniak mentioned this pull request Sep 17, 2020
Merged
@trop
Copy link
Contributor

@trop trop bot commented Sep 17, 2020

@miniak has manually backported this PR to "9-x-y", please check out #25521
codebytere pushed a commit that referenced this pull request Sep 17, 2020
@miniak
build: fix build with enable_pdf_viewer=false (#25494) (#25508)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
552ec22
codebytere pushed a commit that referenced this pull request Sep 18, 2020
@miniak
build: fix build with enable_pdf_viewer=false (#25494) (#25521)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3aa207c
@miniak miniak mentioned this pull request Sep 18, 2020
Merged
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon

@alexeykuzmin alexeykuzmin

@codebytere codebytere

Assignees
No one assigned
Labels
merged/10-x-y merged/11-x-y merged/9-x-y
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@miniak @nornagon @alexeykuzmin @codebytere
You can’t perform that action at this time.