Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40313: speed up bytes.hex() #19594

Merged
merged 2 commits into from Apr 21, 2020
Merged

bpo-40313: speed up bytes.hex() #19594

merged 2 commits into from Apr 21, 2020

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Apr 19, 2020 •
edited by miss-islington

@gpshead gpshead self-assigned this Apr 20, 2020
@gpshead
Copy link
Member

gpshead commented Apr 20, 2020

The code looks great, a natural unrolling to avoid all the conditionals within. Would you please add a NEWS entry about the performance improvement using blurb or blurb-it?

@gpshead gpshead added performance Performance or resource usage 🤖 automerge PR will be merged once it's been approved and all CI passed labels Apr 21, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Apr 21, 2020

@sweeneyde: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6a9e80a into python:master Apr 21, 2020
4 checks passed
@vstinner
Copy link
Member

vstinner commented Apr 21, 2020

I hesitated to do something very similar when I wrote my PR #19535 :-) Nice optimization.

@sweeneyde sweeneyde deleted the hexperf branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

Assignees

@gpshead gpshead

Labels
performance Performance or resource usage 🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sweeneyde @gpshead @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot