Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/tmp/build_root/environment/ uses python 2.7 #109

Closed
JulienPalard opened this issue Aug 1, 2017 · 7 comments
Closed

/tmp/build_root/environment/ uses python 2.7 #109

JulienPalard opened this issue Aug 1, 2017 · 7 comments

Comments

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Aug 1, 2017

The docsbuild venv, from https://github.com/python/psf-salt/blob/master/salt/docs/init.sls#L38 runs python 2.7.

It's only used to run sphinx (not the docsbuild script itself) and I always (by "mistake") built it using "python3 -m venv" when building locally and it always worked perfectly, so the upgrade looks safe.

However as I almost never used salt, I'm still unsure salt is able to upgrade this cleanly, according to the docs a - python: python3 may be enough, if someone knows...

@MarkMangoba
Copy link
Contributor

@MarkMangoba MarkMangoba commented Aug 4, 2017

@ewdurbin can you review? It looks like python: python3 is the answer.

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Aug 4, 2017

yes, that should work but will not recreate the virtualenv.

FWIW the distro we're running for docs will provide us with python 3.4

I'll open a PR with what I think would be a good first step

@MarkMangoba
Copy link
Contributor

@MarkMangoba MarkMangoba commented Aug 4, 2017

@ewdurbin I did see adding python3-dev, that makes sense. Thank you for taking a look!

@JulienPalard
Copy link
Member Author

@JulienPalard JulienPalard commented Aug 4, 2017

Thanks!

@ewdurbin And thanks for mentionning it's Python 3.4, I just tested and blurb is not compatible with Python 3.4 due to (at least) a SyntaxError: can use starred expression only as assignment target.

@JulienPalard
Copy link
Member Author

@JulienPalard JulienPalard commented Aug 4, 2017

@ewdurbin We tried to make blurb work in Python 3.4 (python/core-workflow#170), but we encontred an old bug that has been fixed now (python/core-workflow#171). So we're unsure what's the easiest way... either try to patch, either accept the bug, either upgrade the machine.

Is there a chance docs.iad1.psf.io can get an upgrade?

@ewdurbin
Copy link
Member

@ewdurbin ewdurbin commented Aug 4, 2017

@JulienPalard we should be able to pull a more recent release via PPA, I'll check into it.

@JulienPalard
Copy link
Member Author

@JulienPalard JulienPalard commented Aug 8, 2017

Since python/docsbuild-scripts@90ed1d0 the python3.6 venv is used and it works, thanks.

/srv/docsbuild/environment/ can now be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.