Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting volume with scroll wheel is not working. #573

Open
wildcard-f8 opened this issue Oct 4, 2020 · 3 comments
Open

Adjusting volume with scroll wheel is not working. #573

wildcard-f8 opened this issue Oct 4, 2020 · 3 comments
Assignees

Comments

@wildcard-f8
Copy link

@wildcard-f8 wildcard-f8 commented Oct 4, 2020

Behavior of the program
When I hover over the volume and try to adjust it with the scroll wheel it just scrolls the page. I've read in a closed issue that this feature was supposed have been implemented.

Expected behavior
Hovering over the volume and using the scroll wheel should increase/decrease volume.

To Reproduce

  1. Open video
  2. Hover over volume bar
  3. Scroll up or down

Desktop (please complete the following information):

  • OS: Manjaro
  • OS Version: 20.1.1 Mikah
  • FreeTube version: v0.8.0 Beta
@wildcard-f8 wildcard-f8 added the bug label Oct 4, 2020
@GilgusMaximus GilgusMaximus added enhancement and removed bug labels Oct 4, 2020
@GilgusMaximus
Copy link
Contributor

@GilgusMaximus GilgusMaximus commented Oct 4, 2020

Yes. You probably saw that in #309.
However these old issues were all related to the old FreeTube. A lot of these small things didn't make it over to the new version. Either because new modules were used that simply do not allow copy pasting of code or because the time frame for the rewrite release was too short to focus on some small features.

So this must be implemented again.

Might be a good first issue for new contributors tho.
Taking a look at src\renderer\components\ft-video-player\ might be a good start as there are the events specified for the player.

@TDDR
Copy link

@TDDR TDDR commented Oct 4, 2020

Hello, I just found this app by browsing the trending topics in Github. First off, love the idea of the app in general. I have been trying to get away from google's trackers for some time now so this is a great alternative!

Second, I would like to be assigned this issue. I am new to contributing and feel like this would be a good issue for me to tackle that's not something mundane like writing documentation.

@PrestonN
Copy link
Member

@PrestonN PrestonN commented Oct 4, 2020

Hello! Feel free to work on this if this is something you'd like to take a look at. Let me know if you have any questions about the project. Thank you so much for wanting to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.