Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't override user provided title and body when --fill is used #1994
+6
−2
Conversation
60cfee8
to
b16308c
bigcook12345
commented
Sep 27, 2020
|
That's why I corrected my typo. No harm, hopefully it helped out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
msfjarvis commentedSep 27, 2020
•
edited
Fixes #1400
I'm not a Go developer and couldn't find any pre-existing tests for the
--fillflag so haven't added any in this PR. Existing tests (ran usingmake test) still pass.I created this PR using my generated binary with this command:
./bin/gh pr create -t "Don't override user provided title and body when --fill is used" --fill -dso I guess that is a test in itself :D