Skip to content

/ cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add make clean to remove bin and manpages #1776

Merged
merged 3 commits into from Sep 18, 2020
Merged

chore: add make clean to remove bin and manpages #1776

merged 3 commits into from Sep 18, 2020

Conversation

@zacanger
Copy link
Contributor

zacanger commented Sep 18, 2020

No description provided.

@vedantkarandikar
vedantkarandikar suggested changes Sep 18, 2020
View changes
Copy link

vedantkarandikar left a comment •
edited

Suggest using rm -rf ./bin
@mislav
mislav requested changes Sep 18, 2020
View changes
Copy link
Member

mislav left a comment

Thank you for the suggestion!

I would suggest to also add .PHONY: clean under the new task.

Also, shouldn't clean remove all possible products of our Makefile? If so, then I would also suggest removing the products of manpages, which is the share/ directory.
zacanger added 2 commits Sep 18, 2020
@zacanger
chore: add make clean to remove bin
Verified
This commit was signed with a verified signature.
zacanger zacanger
GPG key ID: F758A5EBFC761412 Learn about signing commits
349d5fe
@zacanger
chore: add phony and rm manpages
Verified
This commit was signed with a verified signature.
zacanger zacanger
GPG key ID: F758A5EBFC761412 Learn about signing commits
Loading status checks…
b6e0399
@zacanger
Copy link
Contributor Author

zacanger commented Sep 18, 2020 •
edited

Oh good call, I overlooked manpages.
@zacanger zacanger requested a review from mislav Sep 18, 2020
@zacanger zacanger changed the title chore: add make clean to remove bin chore: add make clean to remove bin and manpages Sep 18, 2020
@mislav
mislav requested changes Sep 18, 2020
View changes
Makefile Outdated Show resolved Hide resolved
@zacanger
chore: condense rms
Verified
This commit was signed with a verified signature.
zacanger zacanger
GPG key ID: F758A5EBFC761412 Learn about signing commits
Loading status checks…
22a910c
@zacanger zacanger requested a review from mislav Sep 18, 2020
@mislav
mislav approved these changes Sep 18, 2020
View changes
Copy link
Member

mislav left a comment •
edited

Thank you!
@mislav mislav merged commit f6aa6b0 into cli:trunk Sep 18, 2020
4 checks passed
4 checks passed
build (ubuntu-latest)
Details
build (windows-latest)
Details
build (macos-latest)
Details
build-minimum
Details
@zacanger zacanger deleted the zacanger:chore/make-clean branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedantkarandikar vedantkarandikar

@mislav mislav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zacanger @mislav @vedantkarandikar
You can’t perform that action at this time.