Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix race condition when fetching from and deleting a temporary remote #1250
Conversation
|
Looks good to me! All PR's I viewed with error before are now appearing just fine. I tested PR's in the gitcoin and github repositories. |
3f8e31d
into
master
4 checks passed
4 checks passed
VisualStudio
Build #8209122 was skipped due to a previously successful build of the same tree.
Details
jcansdale
added a commit
that referenced
this pull request
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes an issue where a remote was sometimes deleted before a PR had finnished being fetched from it. It failed a lot on large repos but seemed to work on smaller ones.
This issue can be easily reproduced as follows:
git clone https://github.com/bitcoin/bitcoin.gitFile > Open > Folder...and select thebitcoinfolder.GitHubpane (viaTeam Explorer > Pull Requests).BTW,
bitcoin/bitcoinis a good test for a repo with a whole bunch of PRs.Fixes #1249