Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom UIContext to load GitHubPackage / PullRequestStatusBarPackage in context of active repo #1512

Merged
merged 7 commits into from Mar 5, 2018

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Mar 2, 2018

Depends on #1396

This PR does the following:

  • Adds the custom UIContext Guids.UIContext_Git which is activated when a repository is active
  • Changes PullRequestStatusBarPackage to auto-load on UIContext_Git
  • Changes GitHubPackage to auto-load on UIContext_Git
  • Auto-load using a background thread
  • Ensure that GitHubPackage completes menu initialization
    • This is necessary when it's loaded on demand before a command executes

Fixes #1511

jcansdale added 2 commits Mar 2, 2018
Make GitHubPackage auto-load on backgroundLoad thread.
Copy link
Collaborator

@shana shana left a comment

This is awesome, great job!

jcansdale added 2 commits Mar 2, 2018
We no longer need to use `IVSGitExt` to initialize the PR status bar when there is an active Git repository.
We must await InitializeMenus to ensure that menus are ready.
SwitchToMainThreadAsync doesn't exit until a solution has loaded.
@jcansdale jcansdale force-pushed the fixes/1511-Git-UIContext branch from 94bce3d to d951127 Mar 2, 2018
@jcansdale jcansdale mentioned this pull request Mar 2, 2018
8 of 9 tasks complete
@jcansdale jcansdale changed the title Only auto-load GitHubPackage when there is an active repository Use custom UIContext to load GitHubPackage / PullRequestStatusBarPackage in context of active repo Mar 2, 2018
@jcansdale jcansdale changed the base branch from refactor/convert-VSGitExt-to-service to feature/show-current-pr Mar 2, 2018
@jcansdale jcansdale changed the base branch from feature/show-current-pr to master Mar 2, 2018
@jcansdale jcansdale changed the base branch from master to feature/show-current-pr Mar 2, 2018
@jcansdale jcansdale changed the base branch from feature/show-current-pr to master Mar 5, 2018
jcansdale added 3 commits Mar 5, 2018
@shana
shana approved these changes Mar 5, 2018
@jcansdale jcansdale merged commit 804f3b3 into master Mar 5, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jcansdale jcansdale deleted the fixes/1511-Git-UIContext branch Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.