Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Show current PR on status bar and allow navigation to PR details MVP #1102
Conversation
|
@donokuda I'm going to try making this UI do something when clicked on. It will the PR detail pane for the active PR and ideally select the corresponding file in the PR that's currently being edited. We could get even more fancy and navigate to the exact same line (giving the user an easy way to comment). Please feel free to hack on the UI. I'll work on the wiring up. If I touch the XAML, it's just an example to show the wiring working. Otherwise, the XAML is all yours. Does that make sense? |
|
@jcansdale Yup! I'm currently working on #1080 and once that's in a good place I'll hop over in on here. |
|
I tested this branch out but it looks like it's not showing the PR information for me. Is there anything I should do to get it to show? I'm on VS2017 fwiw.
|
|
@donokuda Thanks for the heads up.
Ah, it seems it doesn't work on VS 2017. |
I've added a workaround that will hopefully fix this issue. The code isn't pretty, but should at least put the UI where it's supposed to be. I'll do it properly when I get the chance. |
| } | ||
|
|
||
| void ShowPullRequestStatus() | ||
| { |
jcansdale
Sep 8, 2017
Author
Collaborator
This should be in its own package, no piggy backing off InlineReviewsPackage.
This should be in its own package, no piggy backing off InlineReviewsPackage.
This isn't pretty but gets the UI control to where we want it.
Initialize with InlineReviewsPackage. This should probably initialize earlier from its own package.
Remove view when there is no PR session.
| </Button> | ||
| <Grid.ToolTip> | ||
| <TextBlock Text="{Binding Title}" /> | ||
| </Grid.ToolTip> |
|
This is now merged with master and should be working again. Not sure why the CI build just failed. |
|
Starting off the feature branch with an MVP version. |
This adds some UI that displays information about any PR associated with the current branch. At the moment it simply shows the PR number and has a tooltop for its title. This was to show what data it is currently populated with.
Maybe we could allow navigation the the PR details pane or let the user toggle modes for adding comments?
This primarily a branch for experimenting with different UI ideas.
Fixes #1097