Skip to content

bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX.#21458

Merged
miss-islington merged 2 commits intopython:masterfrom
serhiy-storchaka:unpickle-bad-newobj_ex
Jul 13, 2020
Merged

bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX.#21458
miss-islington merged 2 commits intopython:masterfrom
serhiy-storchaka:unpickle-bad-newobj_ex

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 13, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue41288

Automerge-Triggered-By: @tiran

tiran
tiran requested changes Jul 13, 2020
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Jul 13, 2020

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka @tiran
Apply suggestions from code review
e388a55 
Co-authored-by: Christian Heimes <christian@python.org>
serhiy-storchaka
serhiy-storchaka commented Jul 13, 2020
View reviewed changes
Copy link
Member Author

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again.

tiran
tiran approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@miss-islington
Copy link
Contributor

miss-islington commented Jul 13, 2020

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 4f309ab into python:master Jul 13, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 13, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Jul 13, 2020

GH-21459 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2020
@serhiy-storchaka @miss-islington
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
916bfbc 
Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jul 13, 2020

GH-21460 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2020
@serhiy-storchaka @miss-islington
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
10a5083 
Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jul 13, 2020
@miss-islington @serhiy-storchaka
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (GH-21458)
f56c75e 
Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 13, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 13, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 13, 2020

GH-21461 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 13, 2020

GH-21462 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2020
@serhiy-storchaka @miss-islington
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
5c2d819 
Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2020
@serhiy-storchaka @miss-islington
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
6db83b7 
Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jul 13, 2020
@miss-islington @serhiy-storchaka
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (GH-21458)
57c984f 
Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 13, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 13, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

ned-deily pushed a commit that referenced this pull request Jul 13, 2020
@miss-islington @serhiy-storchaka
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (GH-21458) (G…
620e276 
…H-21461)

Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ned-deily pushed a commit that referenced this pull request Jul 13, 2020
@miss-islington @serhiy-storchaka
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (GH-21458) (G…
6463cf0 
…H-21462)

Automerge-Triggered-By: @tiran
(cherry picked from commit 4f309ab)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@serhiy-storchaka @shihai1991
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
26c9c70 
Automerge-Triggered-By: @tiran
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@serhiy-storchaka @shihai1991
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
36f7b63 
Automerge-Triggered-By: @tiran
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@serhiy-storchaka
bpo-41288: Fix a crash in unpickling invalid NEWOBJ_EX. (pythonGH-21458)
9895fc6 
Automerge-Triggered-By: @tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @bedevere-bot @miss-islington @tiran @ned-deily @the-knights-who-say-ni

Comments