Skip to content

/ docker-node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm log level exclusion for 0.10 and 0.12 #155

Merged
merged 4 commits into from Apr 18, 2016
Merged

Npm log level exclusion for 0.10 and 0.12 #155

merged 4 commits into from Apr 18, 2016

Conversation

@chorrell
Copy link
Contributor

chorrell commented Apr 18, 2016

This updates the update.sh script to ensure that the 0.10 and 0.12 images do not have npm log info set per discussion in #144 (comment)

We'll revisit this at some point pending a final decision on #57
chorrell added 4 commits Apr 16, 2016
@chorrell
Don't set NPM_CONFIG_LOGLEVEL
Loading status checks…
4de53f0
@chorrell
Revert "Don't set NPM_CONFIG_LOGLEVEL"
cef254c 
This reverts commit 4de53f0.
@chorrell
Merge remote-tracking branch 'upstream/master'
696a85f
@chorrell
Don't set npm log info for 0.10 and 0.12.
Loading status checks…
4285b7a 
Reference: #57, #144
@Starefossen
Copy link
Member

Starefossen commented Apr 18, 2016

LGTM 😄
@chorrell
Copy link
Contributor Author

chorrell commented Apr 18, 2016

Test build looks good!

Merging :)
@chorrell chorrell merged commit 5bde647 into nodejs:master Apr 18, 2016
1 check passed
1 check passed
Travis CI via nodejs-github-bot all tests passed
Details
@chorrell chorrell deleted the chorrell:npm-log-level-exclusions branch May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@chorrell @Starefossen
You can’t perform that action at this time.