Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always default to GitHub login #2479

Merged
merged 7 commits into from Mar 17, 2020
Merged

Always default to GitHub login #2479

merged 7 commits into from Mar 17, 2020

Conversation

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Mar 15, 2020

Default to GitHub login, even when already authenticated. User might want to authenticate as a different user. Having the default change can be confusing.

  • Set default LoginMode to LoginMode.DotComOrEnterprise

Fixes #2478

jcansdale added 2 commits Mar 15, 2020
@jcansdale jcansdale requested a review from daschult Mar 15, 2020
jcansdale added 5 commits Mar 16, 2020
…github/VisualStudio into fixes/2478-default-github-login
@jcansdale jcansdale merged commit 2ff1ca4 into master Mar 17, 2020
2 checks passed
2 checks passed
build
Details
github.VisualStudio #2.11.82+f323473373 succeeded
Details
@jcansdale jcansdale deleted the fixes/2478-default-github-login branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.