Skip to content

bpo-38967: Improve the error msg for reserved _sunder_ names in enum#18370

Merged
miss-islington merged 1 commit intopython:masterfrom
ZackerySpytz:bpo-38967-enum-_sunder_-error-msg
Sep 13, 2020
Merged

bpo-38967: Improve the error msg for reserved _sunder_ names in enum#18370
miss-islington merged 1 commit intopython:masterfrom
ZackerySpytz:bpo-38967-enum-_sunder_-error-msg

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Feb 6, 2020 •
edited by miss-islington
Loading

@ZackerySpytz
Copy link
Copy Markdown
Contributor Author

ZackerySpytz commented Feb 6, 2020

IMO, this doesn't need a news entry.

@ethanfurman
Copy link
Copy Markdown
Member

ethanfurman commented Sep 13, 2020

Status checks are stuck; closing and reopening to try to get them to run again.

@ethanfurman ethanfurman reopened this Sep 13, 2020
@ethanfurman ethanfurman self-assigned this Sep 13, 2020
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Sep 13, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@nosamproductions

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

CLA Missing

Our records indicate the following people have not signed the CLA:

@Akuli

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ethanfurman ethanfurman force-pushed the bpo-38967-enum-_sunder_-error-msg branch from 7521285 to 0e35335 Compare September 13, 2020 19:26
@pganssle pganssle removed their request for review September 13, 2020 20:01
@miss-islington miss-islington merged commit 2ec6752 into python:master Sep 13, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@ZackerySpytz @xzy3-cdc
bpo-38967: Improve the error msg for reserved _sunder_ names in enum (p…
d20d0b8 
…ythonGH-18370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@abalkin abalkin Awaiting requested review from abalkin

@asvetlov asvetlov Awaiting requested review from asvetlov

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@brettcannon brettcannon Awaiting requested review from brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@gpshead gpshead Awaiting requested review from gpshead

@methane methane Awaiting requested review from methane

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@rhettinger rhettinger Awaiting requested review from rhettinger

@tiran tiran Awaiting requested review from tiran

@warsaw warsaw Awaiting requested review from warsaw

Assignees

@ethanfurman ethanfurman

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @ethanfurman @the-knights-who-say-ni @bedevere-bot @miss-islington