Skip to content

/ Unity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting progress updating #876

Merged
merged 1 commit into from Jul 30, 2018
Merged

Correcting progress updating #876

merged 1 commit into from Jul 30, 2018

Conversation

@StanleyGoldman
Copy link
Member

StanleyGoldman commented Jul 30, 2018 •
edited

Fixes #854

A simple math error caused the computation of the progress delta to be infinitesimally small.
@StanleyGoldman
Correcting progress delta computation
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
9d2f1df
@shana
Copy link
Contributor

shana commented Jul 30, 2018

@shana
shana approved these changes Jul 30, 2018
View changes
Copy link
Contributor

shana left a comment

doh!
@StanleyGoldman StanleyGoldman merged commit 6e0d0bc into master Jul 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@StanleyGoldman StanleyGoldman deleted the fixes/unzip-progress branch Jul 30, 2018
@StanleyGoldman StanleyGoldman mentioned this pull request Aug 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shana shana

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@StanleyGoldman @shana
You can’t perform that action at this time.