Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCleanups to #300 #400
Merged
Cleanups to #300 #400
Conversation
209de48
into
fixes/api-failure-switch-auth-view
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
shana commentedNov 2, 2017
Moving message logic into the AuthenticationView, and clearing the UI when going back and finishing so the error messages don't persist.
@StanleyGoldman I'm having an issue where it hangs at the end of the login because
LoadCredentialHelpernever finishes. The last message I get from the log is171101-21:34:17 TRACE [ 1] <GitCredentialManager> Loading Credential Helperand debugging equally stops there. Can you repro?