Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PublishView to support long error messages #361

Merged
merged 15 commits into from Oct 23, 2017

Conversation

@StanleyGoldman
Copy link
Member

StanleyGoldman commented Oct 13, 2017

Fixes #199

Trying to fix this problem
img

I did this...
img

Making the window bigger and putting the error message below the button.

…he button
donokuda and others added 10 commits Oct 13, 2017
@@ -20,7 +20,8 @@ class PublishView : Subview
private const string SelectedOwnerLabel = "Owner";
private const string RepositoryNameLabel = "Repository Name";
private const string DescriptionLabel = "Description";
private const string CreatePrivateRepositoryLabel = "Create as a private repository";
private const string CreatePrivateRepositoryLabel = "Make repository private";
private const string PublishLimtPrivateRepositoriesError = "You are currently at your limt of private repositories";

This comment has been minimized.

@shana

shana Oct 23, 2017

Contributor

/me 👀 limt

GUILayout.EndHorizontal();

GUILayout.Space(Styles.PublishViewSpacingHeight);
GUILayout.Label("Publish to GitHub", EditorStyles.boldLabel);

This comment has been minimized.

@shana

shana Oct 23, 2017

Contributor

This string should be in a const

Copy link
Contributor

shana left a comment

Some string adjustments needed

@shana
shana approved these changes Oct 23, 2017
@shana shana merged commit c14fb8d into master Oct 23, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@shana shana deleted the fixes/long-publish-error-message branch Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.