Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping the authentication if the username doesn't match in the keychain #298

Merged
merged 3 commits into from Sep 12, 2017

Conversation

@StanleyGoldman
Copy link
Member

StanleyGoldman commented Sep 11, 2017

Fixes #177

Depends on:

@shana
shana approved these changes Sep 12, 2017
Copy link
Contributor

shana left a comment

Looks good, just wondering why the spurious logging change

@shana
shana approved these changes Sep 12, 2017
Copy link
Contributor

shana left a comment

LGTM except for that totally unrelated formatting change 👀

@@ -55,7 +55,7 @@ public IKeychainAdapter Connect(UriString host)
KeychainAdapter keychainAdapter = FindOrCreateAdapter(host);
var cachedConnection = connectionCache[host];

logger.Trace($@"Loading KeychainAdapter Host:""{host}"" Cached Username:""{cachedConnection.Username}""");
logger.Trace("Loading KeychainAdapter Host:\"{0}\" Cached Username:\"{1}\"", host, cachedConnection.Username);

This comment has been minimized.

@shana

shana Sep 12, 2017

Contributor

Formatting change that doesn't need to be here

@StanleyGoldman StanleyGoldman force-pushed the fixes/kepp-auth-if-user-does-not-match branch from d3accd9 to 5c07e42 Sep 12, 2017
@shana
shana approved these changes Sep 12, 2017
@StanleyGoldman StanleyGoldman merged commit 600faeb into master Sep 12, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@StanleyGoldman StanleyGoldman deleted the fixes/kepp-auth-if-user-does-not-match branch Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.