Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMaking the standalone api nicer to use #989
Merged
Conversation
|
Looks good, otherwise one nit pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
shana commentedDec 21, 2018
I did a little app (https://github.com/shana/unity-runtime-git) to test using the api at runtime, and I had to do some tweaks to make it nicer to use. These are those tweaks:
InitializeRepository(path to repository)onDefaultEnvironmentdoes the useful thing of setting the base path on the FileSystem object, which means any shell commands and path manipulations are going to assume that path to repository as the base for all relative paths and working directory paths. Which is handy! Only the logic that we currently have makes it impossible to callInitializeRepositorytwice (it just ignores it), so it's not easy to switch these paths.