Skip to content

docs: explain what newEvent() is#37386

Closed
andrewasche wants to merge 1 commit into
angular:masterfrom
andrewasche:update-hero-detail
Closed

docs: explain what newEvent() is#37386
andrewasche wants to merge 1 commit into
angular:masterfrom
andrewasche:update-hero-detail

Conversation

@andrewasche

Copy link
Copy Markdown
Contributor

Currently the newEvent() method is not clear. At times readers mistake it as a typo because it looks like there should be a space. This comments explains its use and references its definition.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Currently the newEvent() method is not clear. At times readers mistake it as a typo because it looks like there should be a space. This comments explains its use and references its definition.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@gkalpak

gkalpak commented Jun 2, 2020

Copy link
Copy Markdown
Member

I'm afraid this is superceded by #37251 (see #36967 (comment)).
Thx for working on this, @andrewasche 馃憤

@gkalpak gkalpak closed this Jun 2, 2020
@kapunahelewong

Copy link
Copy Markdown
Contributor

Oh, I'm sorry, @andrewasche! I didn't know about that one. Your work was super anyway! If you would like to work on another docs contribution please feel free to let me know. I'll keep an eye out for you. :)

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants