Skip to content

docs: ng generate module command doc change#38480

Closed
akashsolanki wants to merge 1 commit into
angular:masterfrom
akashsolanki:simplify-ng-generate-module-doc
Closed

docs: ng generate module command doc change#38480
akashsolanki wants to merge 1 commit into
angular:masterfrom
akashsolanki:simplify-ng-generate-module-doc

Conversation

@akashsolanki

@akashsolanki akashsolanki commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 38461

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@akashsolanki akashsolanki mentioned this pull request Aug 15, 2020
Closed
@geromegrignon

geromegrignon commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

According to the Contribution Guidelines, your commit message must use a precise format : https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

@akashsolanki akashsolanki force-pushed the simplify-ng-generate-module-doc branch from d3f2f40 to ca89561 Compare August 18, 2020 15:38
@akashsolanki

akashsolanki commented Aug 18, 2020

Copy link
Copy Markdown
Contributor Author

According to the Contribution Guidelines, your commit message must use a precise format : https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

Changed the commit message. Thanks for pointing out.

@ngbot ngbot Bot added this to the needsTriage milestone Aug 25, 2020
@kapunahelewong kapunahelewong force-pushed the simplify-ng-generate-module-doc branch from ca89561 to b9a172b Compare August 28, 2020 13:56
kapunahelewong
kapunahelewong approved these changes Aug 28, 2020
View reviewed changes

@kapunahelewong kapunahelewong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks, @akashsolanki! I驶ve rebased to see if we can get all the tests passing. This is a nice improvement to that doc. 馃専

LGTM!

Reviewed-for: global-docs-approvers

@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Aug 28, 2020
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Aug 28, 2020
@kapunahelewong kapunahelewong force-pushed the simplify-ng-generate-module-doc branch from b9a172b to 9d35a09 Compare August 31, 2020 12:52
@kapunahelewong kapunahelewong removed the request for review from pkozlowski-opensource August 31, 2020 13:35
@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Aug 31, 2020
josephperrott pushed a commit that referenced this pull request Aug 31, 2020
@akashsolanki @josephperrott
docs: ng generate module command doc change (#38480)
d366b17 
PR Close #38480
josephperrott pushed a commit that referenced this pull request Aug 31, 2020
@akashsolanki @josephperrott
docs: ng generate module command doc change (#38480)
659705a 
PR Close #38480
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@akashsolanki @profanis
docs: ng generate module command doc change (angular#38480)
e7d9410 
PR Close angular#38480
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 1, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kapunahelewong kapunahelewong kapunahelewong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@akashsolanki @geromegrignon @kapunahelewong @sonukapoor @googlebot