Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant indent_style from editorconfig #205

Merged

Conversation

@thefourtheye
Copy link
Contributor

thefourtheye commented Nov 24, 2018

indent_style is applied to all the files based on [*] entry. We
don't have to specify the same for package.json explicitly.

`indent_style` is applied to all the files based on `[*]` entry. We
don't have to specify the same for `package.json` explicitly.
@thefourtheye thefourtheye requested a review from williamkapke Nov 24, 2018
@addaleax

This comment was marked as resolved.

@thefourtheye

This comment was marked as resolved.

Copy link
Member

addaleax left a comment

Oops, mixed up indent_style vs indent_size options. LGTM!

@thefourtheye
Copy link
Contributor Author

thefourtheye commented Nov 24, 2018

Oops, mixed up indent_style vs indent_size options.

😅 No problem. Thanks for the review 🙂

@phillipj phillipj merged commit 5cb45a8 into nodejs:master Jan 11, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@thefourtheye thefourtheye deleted the thefourtheye:remove-superfluent-entry-in-editorconfig branch Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.