Skip to content

/ electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only focus a webContents if the window was not initially hidden #25292

Merged
merged 1 commit into from Sep 4, 2020
Merged

fix: only focus a webContents if the window was not initially hidden #25292

merged 1 commit into from Sep 4, 2020
+17 −6

Conversation

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Sep 2, 2020

Fixes #25287

Notes: Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false
@MarshallOfSound
fix: only focus a webContents if the window was not initially hidden
Verified
This commit was signed with a verified signature.
MarshallOfSound Samuel Attard
GPG key ID: FB94249299E904FE Learn about signing commits
Loading status checks…
f13d05f
@zcbenz
zcbenz approved these changes Sep 3, 2020
View changes
Copy link
Member

zcbenz left a comment

I tested a few cases and I confirm it does not have side effects.
@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 3, 2020
@codebytere
codebytere approved these changes Sep 4, 2020
View changes
@zcbenz zcbenz merged commit a6b9f9d into master Sep 4, 2020
16 of 17 checks passed
16 of 17 checks passed
build-mac Workflow: build-mac
Details
Backportable? - 10-x-y Backport Failed
Details
Artifact Comparison No Changes
Details
Backportable? - 11-x-y Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20200902.56 succeeded
Details
electron-arm64-testing Build #20200902.57 succeeded
Details
electron-woa-testing Build #20200903.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk
Copy link

release-clerk bot commented Sep 4, 2020

Release Notes Persisted

Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false
@zcbenz zcbenz deleted the fix-focus-on-hidden-window branch Sep 4, 2020
@trop
Copy link
Contributor

trop bot commented Sep 4, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.
@trop trop bot added needs-manual-bp/10-x-y and removed target/10-x-y labels Sep 4, 2020
@trop trop bot mentioned this pull request Sep 4, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 4, 2020

I have automatically backported this PR to "11-x-y", please check out #25323
@MarshallOfSound MarshallOfSound mentioned this pull request Sep 4, 2020
Open
@trop
Copy link
Contributor

trop bot commented Sep 4, 2020

@MarshallOfSound has manually backported this PR to "10-x-y", please check out #25330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz

@codebytere codebytere

Assignees
No one assigned
Labels
in-flight/10-x-y merged/11-x-y
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Missing focus event on app activation, for window created with show: false
3 participants
@MarshallOfSound @zcbenz @codebytere
You can’t perform that action at this time.